Making my JavaScript/jQuery cleaner -


i'm trying improve how clean javascript/jquery , wondering if has pointers.

when @ doesn't clean... 

if (window.jquery) {     (function ($) {           var podcaption = function ($scope, settings) {               this._settings = $.extend({                   openheight : 75,                 expandheight : 120,                 shrinkheight : 30,                 closeheight : 15,                 timer : ''             }, settings);              this._elements = {                  scope : $scope,                 caption : $('.slider-information', $scope)             };                this.init();         };          podcaption.prototype.init = function() {             var _this = this;               $('.photo-more', _this._elements.caption).live('click', function() {                   _this.expand(_this);             });              _this._elements.caption.mouseenter(function() {                   _this.open(_this);             }).mouseleave(function() {                 _this._settings.timer = settimeout(function() {                      _this.shrink(_this);                 }, 1000);             });          };          podcaption.prototype.changeimage = function(photoindex, image) {             var _this = this;               //shrink out content              _this.close(_this, function() {                  //build content - note i'm doing template stuff here i'm trying make code little less verbose question @ hand                  _this._elements.caption.empty();                 _this._elements.caption.append('<div><div class="photo-description">..</div><div class="photo-more">...</div><div class="photo-info">...</div></div>');                   _this.open(_this, function() {                        _this._settings.timer = settimeout(function() {                          _this.shrink(_this);                     }, 4500);                 });             });          };           podcaption.prototype.expand = function(_this, callback) {             cleartimeout(_this._settings.timer);              var caption = _this._elements.caption;             $('.photo-more', caption).hide();             $('.photo-info', caption).fadein();              caption.animate({ height : _this._setting.expandheight, opacity : 0.8 }, 500, callback);         }          podcaption.prototype.open = function(_this, callback) {             cleartimeout(_this._settings.timer);              _this._elements.caption.animate({ height : _this._setting.openheight, opacity : 0.8 }, 500, callback);         }          podcaption.prototype.close = function(_this, callback) {             cleartimeout(_this._settings.timer);              var caption = _this._elements.caption;             caption.children().fadeout();             caption.animate({ height : _this._setting.closeheight, opacity : 0.2 }, 400, callback);         }          podcaption.prototype.shrink = function(_this, callback) {             cleartimeout(_this._settings.timer);              var caption = _this._elements.caption;             $('.photo-info', caption).fadeout(function() { $('.photo-more', caption).show(); });             caption.animate({ height : _this._setting.shrinkheight, opacity : 0.3 }, 400, callback);         }          $.fn.podcaption = function (options) {             return new podcaption(this, options);         };       })(jquery); }

instead of this:

if (window.jquery) {     (function ($) {              // code          })(jquery); }

how this: 

(function($) {     if ( !$ ) return;     // code }(jquery));

also, this: 

_this._elements.caption.empty(); _this._elements.caption.append('<div>...');

can chained: 

_this._elements.caption.empty().append('<div>...');

or this: 

_this._elements.caption.html('<div>...');

also, define prototype in object literal form: 

podcaption.prototype = {     expand: function(_this, callback) {         // code     },     changeimage: function(photoindex, image) {         // code     },     ... };

Comments

Post a Comment

Popular posts from this blog

apache - Add omitted ? to URLs -

i working on website cms reads page name of query string, e.g. http://exmaple.com/?pagename . trying create rewrite rule rewrite ? . so, user types in /pagename , taken /?pagename try this: rewriteengine on rewritecond %{request_filename} !-d rewritecond %{request_filename} !-f rewriterule ^/?(.*) index.php?$1 [l]
Read more

redirect - bbPress Forum - rewrite to wwww.mysite prohibits login -

i using bbpress installation without wordpress integration. the redirect of rewriteengine @ forum site works: rewriteengine on rewritecond %{http_host} ^forum.mysite.com$ rewriterule (.*)$ http://www.forum.mysite.com/$1 [r=301,l] the problem login pppress. bbpress login not recognize: http://www.forum.mysite/bb-login.php . it redirects to: http://forum.mysite.com/bb-login.php . i tried permalink settings none , name based, same issue. does uses redirect in bbpress or how can eliminate "double" content , redirect permanently www.? i redirected www.forum.mysite.com forum.mysite.com , achieved eliminate "double" content.
Read more

php - How can I stop spam on my custom forum/blog? -

so have custom built forum & blog system of late has been dealing lot of spam. if wordpress use akismet, if different common platform i'm sure i'd find plugin. there kind of static class can download this? using php. i'd still go akismet, if it. uses outside of wordpress, may have pay fee it, depending on use -- check terms , conditions -- it's option , easy implement in php using api. use api key wordpress. com account access. basically, grab whichever php client library takes fancy -- use alex potsides' php5 library -- plug in key, , it's handful of lines of code. here's bare bones of validation straight 1 of live sites: ... if ($akismet) { $akismet->setcommentauthor($name); $akismet->setcommentauthoremail($session->userinfo["email"]); $akismet->setcommentauthorurl(""); $akismet->setcommentcontent($sentence);...
Read more