php - How can I write this Drupal snippet more efficiently? -


i'm working on patch submit registration code module drupal. in short, there more efficient way write code below?

if (module_exists('regcode_voucher')) {   $cnfg = variable_get('regcode_voucher_display', array('regform' => 'regform'));   if (empty($cnfg['regform'])) {     return;   } }

it seems should able reduce 1 if statement && combining 2 conditions, haven't found syntax or necessary php array function allow me that.

in case context helps, regcode_voucher sub-module allows users enter registration code on user edit page. on our sites, after "beta" period, want simplify registration form removing registration code field; we'd users still able enter code on account edit page. code above part of patch allows regcode's hook_user changes bypassed.

code looks good, efficient want? little changes may be:

if (module_exists('regcode_voucher')) {   $cnfg = variable_get('regcode_voucher_display', null);   if ($cnfg) {     // actions   } }

and don't recommend merge if..., code should clear , simpler understand. if merge these optimizing, win "tiny" milliseconds real-live processors, lost clean code.


Comments

Post a Comment

Popular posts from this blog

apache - Add omitted ? to URLs -

i working on website cms reads page name of query string, e.g. http://exmaple.com/?pagename . trying create rewrite rule rewrite ? . so, user types in /pagename , taken /?pagename try this: rewriteengine on rewritecond %{request_filename} !-d rewritecond %{request_filename} !-f rewriterule ^/?(.*) index.php?$1 [l]
Read more

redirect - bbPress Forum - rewrite to wwww.mysite prohibits login -

i using bbpress installation without wordpress integration. the redirect of rewriteengine @ forum site works: rewriteengine on rewritecond %{http_host} ^forum.mysite.com$ rewriterule (.*)$ http://www.forum.mysite.com/$1 [r=301,l] the problem login pppress. bbpress login not recognize: http://www.forum.mysite/bb-login.php . it redirects to: http://forum.mysite.com/bb-login.php . i tried permalink settings none , name based, same issue. does uses redirect in bbpress or how can eliminate "double" content , redirect permanently www.? i redirected www.forum.mysite.com forum.mysite.com , achieved eliminate "double" content.
Read more

php - How can I stop spam on my custom forum/blog? -

so have custom built forum & blog system of late has been dealing lot of spam. if wordpress use akismet, if different common platform i'm sure i'd find plugin. there kind of static class can download this? using php. i'd still go akismet, if it. uses outside of wordpress, may have pay fee it, depending on use -- check terms , conditions -- it's option , easy implement in php using api. use api key wordpress. com account access. basically, grab whichever php client library takes fancy -- use alex potsides' php5 library -- plug in key, , it's handful of lines of code. here's bare bones of validation straight 1 of live sites: ... if ($akismet) { $akismet->setcommentauthor($name); $akismet->setcommentauthoremail($session->userinfo["email"]); $akismet->setcommentauthorurl(""); $akismet->setcommentcontent($sentence);...
Read more